Bug Found 🐛: We discovered a bug where the prices of assets fetched from the <code>UnilendV2oracle</code> contract using the <code>getChainLinkAssetPrice</code> function are returned as Zero.What is UniLend?UniLend Protocol is a permissionless decentralized money market protocol with lending and borrowing service through smart contracts. UniLend enables users to utilize their cryptocurrencies by supplying collateral to the network that may be borrowed by pledging over-collateralized cryptocurrencies. This creates a secure lending environment where the lender receives a compounded interest rate annually (APY) paid by the borrowers.In this article, we are going to be using the latest version UniLend V2. UniLend is currently live on the Sepolia and zkEVM Testnet.Playing around with UniLendV2We played, we liked, we wrote —&gt; that is what this article is; it is our review of the UniLendV2.Why UniLend? UniLend is completely market-driven. This means there are multiple scenarios under which you need to test/simulate how UniLend Protocol functions. This makes UniLend ideal for BuildBear to test it.Please note, for a thorough review of UniLend, it is imperative that we do a test that pretty much covers all the types of transactions that you will execute on UniLend. That is the (a) Deposit and (b) Borrow transactions, (c) the payback, etc etc. However, the MOST important of all is to be able to see the performance of the dApp with the manipulation of the time. This is WHAT THIS TEST IS ABOUT! It is way larger than you think. We will NOT just lend and borrow; we will manipulate the system to be able to do an edge to edge testing.We could simply test on the Sepolia Testnet, but then:<ol style="list-style-type:decimal;"><li>What about time? Do I wait 1 year to test results? and if I do, will this review be useful at all?</li><li>Do I have the ability to change the Price of the Token? (No).</li></ol>You get the drill. It's basically a lock-out. Cannot use Sepolia Testnet.Could we do the local hardhat fork or anvil fork? Without a doubt. But then, we would need to take some pain in impersonating some accounts to get some ERC20 Tokens; do some more hacks to be able to “see” our transactions and the outcome of each of those and whatnot. Hence, {shameless self-sell} we utilized <a href="http://BuildBear.io">BuildBear.io</a> to create a Private Testnet of the Sepolia Testnet. This allowed us to effectively utilize the UniLendV2 front end.NOTE: Since we are (obviously) a premium user of BuildBear, the <code>chainId</code> that we get from BuildBear is the same chainID that we are forking. Eg, the private Testnet that we created on BuildBear (Name: batman)[ We got a custom name] also has the <code>chainId 11155111</code>, since this Testnet is a fork of the Sepolia.Set-up before the testing: Using our Private Testnet Faucet to mint 20K DAI<figure class="image image_resized" style="width:60.37%;"><img src="https://strapi.buildbear.io/uploads/Untitled_design_7_1_283e587a56.gif" alt="Untitled design (7) (1).gif"></figure>Transaction 1: Lending 20K DAI into the UniLendV2 Protocol<figure class="image image_resized" style="width:26.95%;"><img src="https://strapi.buildbear.io/uploads/Untitled_41_496e258974.png" alt="Untitled (41).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Untitled_41_496e258974.png 127w,https://strapi.buildbear.io/uploads/small_Untitled_41_496e258974.png 407w," sizes="100vw"></figure>Quick Side Note:<ol style="list-style-type:decimal;"><li>Lend APY is the combined effect of all supply and borrow positions on net worth, including incentives. It is possible to have a negative net APY if debt APY is higher than supply APY.</li><li>Health factor Safety of your deposited collateral against the borrowed assets and their underlying value. If the health factor goes below 1, the liquidation of your collateral might be triggered.</li></ol>Transaction 2: Borrowing 5K MaticWe borrowed 5K Matic using the 20K DAI deposited as collateral. At borrow APY of 2.100% With this borrowing and the math used by UniLendV2 Protocol, our Health Factor was 3.15 after the borrowing.<figure class="image image_resized" style="width:24.11%;"><img src="https://strapi.buildbear.io/uploads/Untitled_42_8d05056cbe.png" alt="Untitled (42).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Untitled_42_8d05056cbe.png 91w,https://strapi.buildbear.io/uploads/small_Untitled_42_8d05056cbe.png 293w,https://strapi.buildbear.io/uploads/medium_Untitled_42_8d05056cbe.png 439w," sizes="100vw"></figure>Transaction 3: Lending 5k UFT TokensTransaction 4: Lending 5k USDC TokensThe REAL TestAdvancing the time for a year (Using the BuildBear utility tools we were able to Advance time by a year as shown below).<figure class="image image_resized" style="width:58.25%;"><img src="https://strapi.buildbear.io/uploads/Untitled_design_9_1_0710b616df.gif" alt="Untitled design (9) (1).gif"></figure>Executing different scenariosIn order to facilitate this, it is crucial to have the following abilities:<ol style="list-style-type:decimal;"><li>The ability to modify the price of assets.</li><li>The ability to save the state of the Testnet at different points of testing. This eliminates the need to create multiple Testnets for executing different scenarios. To accomplish this, we have utilized the BuildBear utility tool, as demonstrated below, to create a snapshot of the Testnet at the required points.</li></ol><figure class="image image_resized" style="width:56.81%;"><img src="https://strapi.buildbear.io/uploads/Untitled_design_8_1_e716fb252c.gif" alt="Untitled design (8) (1).gif"></figure>Case 1: The price of Assets Remains the same || The simplest of the testRepaying the Matic we have Borrowed with interest.<figure class="image image_resized" style="width:13.4%;"><img src="https://strapi.buildbear.io/uploads/Screenshot_982_2ad34ebbe8.png" alt="Screenshot (982).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Screenshot_982_2ad34ebbe8.png 155w,https://strapi.buildbear.io/uploads/small_Screenshot_982_2ad34ebbe8.png 496w," sizes="100vw"></figure>Redeeming USDC, UFT, and DAI Tokens we received from our lending positions.<figure class="image image_resized" style="width:42.65%;"><img src="https://strapi.buildbear.io/uploads/Screenshot_984_6706ac58a6.png" alt="Screenshot (984).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Screenshot_984_6706ac58a6.png 245w,https://strapi.buildbear.io/uploads/small_Screenshot_984_6706ac58a6.png 500w,https://strapi.buildbear.io/uploads/medium_Screenshot_984_6706ac58a6.png 750w," sizes="100vw"></figure><ol><li>Case 2: The Price of Assets Increase To change the price of Assets we Impersonated the owner account of <code>UnilendV2oracle</code> and Altered the USDC oracle source address to [0xf46ba822fFb594a2fFcaeCa9994075FD40529059] to change the price of the USDC Token [0x6f14C02Fc1F78322cFd7d707aB90f18baD3B54f5].</li></ol><figure class="image image_resized" style="width:71.88%;"><img src="https://strapi.buildbear.io/uploads/Untitled_47_9049f3e9db.png" alt="Untitled (47).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Untitled_47_9049f3e9db.png 245w,https://strapi.buildbear.io/uploads/small_Untitled_47_9049f3e9db.png 500w,https://strapi.buildbear.io/uploads/medium_Untitled_47_9049f3e9db.png 750w," sizes="100vw"></figure>We encountered a Bug 🐛Then while fetching the price of the <code>USDC</code> [0x6f14C02Fc1F78322cFd7d707aB90f18baD3B54f5] Using <code>getChainLinkAssestPrice</code> the function we encountered the <code>Call_exception</code> error. As shown below.<figure class="image image_resized" style="width:58.32%;"><img src="https://strapi.buildbear.io/uploads/Untitled_51_cbfeb38357.png" alt="Untitled (51).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Untitled_51_cbfeb38357.png 245w,https://strapi.buildbear.io/uploads/small_Untitled_51_cbfeb38357.png 500w," sizes="100vw"></figure>After further inspection, we also found the price of the other tokens that are listed on UniLendV2 are fetching as Zero. (Weth Token Address-0xeD43f81C17976372Fcb5786Dd214572e7dbB92c7)<figure class="image image_resized" style="width:50%;"><img src="https://strapi.buildbear.io/uploads/Untitled_48_ae6ea64809.png" alt="Untitled (48).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Untitled_48_ae6ea64809.png 245w,https://strapi.buildbear.io/uploads/small_Untitled_48_ae6ea64809.png 500w," sizes="100vw"></figure>When we passed the Source Address of the USDC [ 0xf46ba822fFb594a2fFcaeCa9994075FD40529059] into the <code>getChainLinkAssestPrice</code> we got the price As Follows.<figure class="image image_resized" style="width:50%;"><img src="https://strapi.buildbear.io/uploads/Untitled_53_7d3776babb.png" alt="Untitled (53).png" srcset="https://strapi.buildbear.io/uploads/thumbnail_Untitled_53_7d3776babb.png 245w,https://strapi.buildbear.io/uploads/small_Untitled_53_7d3776babb.png 500w," sizes="100vw"></figure><h3>Testing the Issue in-depth</h3>For the purpose of testing the issue, we have used two contracts (both instances of AggregatorV3Interface) as assets and sources and vice versa.The issue seems to be fixed in GitHub, and this is the code<pre><code class="language-javascript">function getChainLinkAssetPrice(address asset) public view returns (int256 price) {
 AggregatorV3Interface source = assetsOracles[asset];
 if(address(source) != address(0)){
 price = getLatestPrice(source);
 }
}
</code></pre>But while testing we got behaviour similar to<pre><code class="language-javascript">function getChainLinkAssetPrice(address asset) public view returns (int256 price) {
 AggregatorV3Interface source = assetsOracles[asset];
 if(address(source) != address(0)){
 price = getLatestPrice(asset); // This is an issue
 }
}
</code></pre>We tested this using a script and storing the value of the asset and the source as<pre><code class="language-plaintext">// address[] assets, address[] sources

["0xf46ba822fFb594a2fFcaeCa9994075FD40529059", "0xf0cd67e684fb8bb227c7d9dc6ff96184c9a72e7c"], ["0xf0cd67e684fb8bb227c7d9dc6ff96184c9a72e7c", "0xf46ba822fFb594a2fFcaeCa9994075FD40529059"]
</code></pre>Both of the contracts implement&nbsp;<code>AggregatorV3Interface</code>&nbsp; and return different values upon invocation by the&nbsp;<code>getLatestPrice</code> function.The contract <code>0xf0cd67e684fb8bb227c7d9dc6ff96184c9a72e7c</code>&nbsp;returns&nbsp;<code>1000000000000000</code>The contract <code>0xf46ba822fFb594a2fFcaeCa9994075FD40529059</code>&nbsp;returns&nbsp;<code>22</code>Upon calling <code>getChainLinkAssetPrice</code> function with&nbsp;<code>0xf0cd67e684fb8bb227c7d9dc6ff96184c9a72e7c</code>&nbsp; it is supposed to return&nbsp;<code>22</code>&nbsp;(because its source is <code>0xf46ba822fFb594a2fFcaeCa9994075FD40529059</code>) but it returned&nbsp;<code>1000000000000000</code>Similarly, upon calling <code>getChainLinkAssetPrice</code> function with&nbsp;<code>0xf46ba822fFb594a2fFcaeCa9994075FD40529059</code>&nbsp; it is supposed to return&nbsp;<code>1000000000000000</code>&nbsp;(because its source is <code>0xf0cd67e684fb8bb227c7d9dc6ff96184c9a72e7c</code>) but it returned&nbsp;<code>22</code>The issue seems to be fixed in GitHub, but the deployed code is behaving in this mannerWe have reported the bug to the UniLend team, and they have also confirmed that the changes on GitHub are not live on Sepolia Yet.Due to this bug, we encountered difficulties in executing Test Case 2 and Case 3.Conclusion: The BuildBear impersonate feature, which enabled us to act as the owner of <code>UnilendV2oracle</code> and change the Price oracle Address, played a crucial role in identifying the issue.Using BuildBear for your QAIf you are DeFi Web3 App and you are looking to either<ol style="list-style-type:decimal;"><li>Create an internal QA Environment for your team, or</li><li>Creating a private testing environment for your community before releasing to the Mainnet, or</li></ol>Come talk to us at <a href="mailto:team@buildbear.io">team@buildbear.io</a> We can help you create your own, 100% customized testing environment, so that you can use it without any hassle.NOTE: Information in this article shouldn’t be taken as Finance Advice.Author: <a href="https://twitter.com/chandan1_">chandan</a>

Twitter post - 22 (2).png

UniLend Protocol is a permissionless decentralized money market protocol with lending and borrowing service through smart contracts. UniLend enables users to utilize their cryptocurrencies by supplying collateral to the network that may be borrowed by pledging over-collateralized cryptocurrencies. 

Testing and Simulating UniLend V2 || Reporting a Price-Oracle Bug

BUILDBEAR // TUTORIALS

Testing and Simulating UniLend V2 || Reporting a Price-Oracle Bug

Let’s get started then, Shall we?

Let’s get started then, Shall we?

Test DApps at Scale.